fix(server): surface producer errors after failed tasks - #1229
Merged
mykytanetipa merged 1 commit intoSep 7, 2026
Conversation
Signed-off-by: dawn <93917549+dawNotPoi@users.noreply.github.com>
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/request_handlers/default_request_handler_v2.py | 92.44% | 92.53% | 🟢 +0.09% |
| Total | 93.05% | 93.06% | ⚪️ 0.00% |
Generated by coverage-comment.yml
dawNotPoi
marked this pull request as ready for review
September 4, 2026 07:15
mykytanetipa
pushed a commit
that referenced
this pull request
Sep 8, 2026
🤖 I have created a release *beep* *boop* --- ## [1.1.4](v1.1.3...v1.1.4) (2026-09-07) ### Features * **itk:** register itk-python-v10-agent as a uv workspace member and update dependency version markers ([#1203](#1203)) ([6eee895](6eee895)) * **itk:** use shared scenarios ([#1201](#1201)) ([b4a0b21](b4a0b21)) ### Bug Fixes * make event queue sink removal idempotent ([#1134](#1134)) ([58c72c6](58c72c6)) * omit artifacts from list tasks responses ([#1212](#1212)) ([35ef52e](35ef52e)) * owner-scope cancel/subscribe and write terminal state on cancel ([#1159](#1159), [#1170](#1170)) ([#1172](#1172)) ([ddbf853](ddbf853)) * prevent first-owner write loss in in-memory stores ([#1194](#1194)) ([bcc489c](bcc489c)) * **server:** let subscriber taps evict on full instead of wedging dispatch ([#1137](#1137)) ([0c2126f](0c2126f)) * **server:** surface producer errors after failed tasks ([#1229](#1229)) ([bc32d7e](bc32d7e)) * **server:** validate push-notification URLs at config creation ([#1173](#1173)) ([3eb88e2](3eb88e2)) * **server:** validate push-notification URLs before dispatch (SSRF hardening) ([#1164](#1164)) ([57a9df3](57a9df3)) * **server:** warn when queue_manager is ignored in DefaultRequestHandlerV2 ([#1153](#1153)) ([08fd223](08fd223)) ### Documentation * **server:** say what the evict-on-full check actually tests ([#1209](#1209)) ([4b7b242](4b7b242)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Blocking
message/sendpreviously stopped consuming as soon as a FAILED Task replacement arrived. If the producer then raised, the subscriber never observed that exception and the request returned the failed Task as a successful RPC result.This keeps a FAILED Task as the fallback response but continues consuming until the current request completes, the stream closes, or the producer error arrives. A clean agent-declared failure still returns its Task; a producer crash now surfaces its original exception. Other terminal states and
return_immediatelyretain their existing behavior.CONTRIBUTINGGuide.Test plan
./scripts/lint.shuv run pytest— 1,987 passed, 90 skipped, 3 xfailed, 1 xpasseduv run pytest --cov=src --cov-report=term-missing— 93% total coverageFixes #1228 🦕
AI assistance
Codex was used for implementation, testing, and independent code review. This Draft remains subject to human review.